Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keras.layers.ReLU docs #48646 #48654

Merged
merged 2 commits into from May 13, 2021
Merged

Fix keras.layers.ReLU docs #48646 #48654

merged 2 commits into from May 13, 2021

Conversation

szutenberg
Copy link
Contributor

threshold should not be negative because ReLU behavior does not match
the docs and it is not ReLU

#48646

@szutenberg
Fix keras.layers.ReLU docs #48646
787ad8c 
threshold should not be negative because ReLU behaviour does not match
the docs and it is not ReLU
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Apr 20, 2021
@google-cla google-cla bot added the cla: yes label Apr 20, 2021
@szutenberg szutenberg mentioned this pull request Apr 20, 2021
Closed
@gbaned gbaned self-assigned this Apr 21, 2021
@gbaned gbaned added comp:keras Keras related issues prtype:bugfix PR to fix a bug labels Apr 21, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 21, 2021
@gbaned gbaned self-requested a review April 21, 2021 06:48
chenmoneygithub
chenmoneygithub approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@chenmoneygithub chenmoneygithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 22, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 22, 2021
@nikitamaia nikitamaia linked an issue Apr 22, 2021 that may be closed by this pull request
ReLU layer wrong result with negative threshold #48646
Closed
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Apr 25, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 26, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 26, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Apr 26, 2021
@szutenberg
Improve checks in keras.layers.ReLU #48646
73bd1ec 
- added checking if negative_slope is None
- added checking if threshold is negative
- updated respective unit tests
- renamed test_threshold_relu_with_invalid_alpha to
  test_threshold_relu_with_invalid_theta
@szutenberg
Copy link
Contributor Author

szutenberg commented Apr 26, 2021 •
edited

pylint errors (too long lines) fixed in 73bd1ec

deeb02
deeb02 approved these changes Apr 30, 2021
View reviewed changes
Copy link

@deeb02 deeb02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for your contribution!

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 30, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 30, 2021
@gbaned gbaned removed the ready to pull PR ready for merge process label Apr 30, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 30, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 30, 2021
@gbaned gbaned removed the ready to pull PR ready for merge process label May 4, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 4, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels May 11, 2021
@copybara-service copybara-service bot merged commit 28c2152 into tensorflow:master May 13, 2021
PR Queue automation moved this from Approved by Reviewer to Merged May 13, 2021
@szutenberg szutenberg deleted the relu_docs_fix branch June 13, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbaned gbaned gbaned approved these changes

@deeb02 deeb02 deeb02 approved these changes

@chenmoneygithub chenmoneygithub Awaiting requested review from chenmoneygithub

Assignees

@gbaned gbaned

Labels
cla: yes comp:keras Keras related issues prtype:bugfix PR to fix a bug ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReLU layer wrong result with negative threshold
5 participants
@szutenberg @chenmoneygithub @gbaned @deeb02 @kokoro-team