Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intel MKL] Fixing python version of IsMklEnabled() method #48685

Conversation

mahmoud-abuzaina
Copy link
Contributor

This PR changes IsMklEnabled() python method which used to consider build flag only to determine if Mkl is enabled. That caused some python tests to fail (like timeline_test) in single binary. Now it also checks the environment variable flag.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Apr 21, 2021
@google-cla google-cla bot added the cla: yes label Apr 21, 2021
@gbaned gbaned self-assigned this Apr 22, 2021
@gbaned gbaned added the comp:mkl MKL related issues label Apr 22, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 22, 2021
@gbaned gbaned requested a review from penpornk April 22, 2021 04:29
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 22, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 22, 2021
@copybara-service copybara-service bot merged commit 8b39577 into tensorflow:master Apr 26, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:mkl MKL related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants