Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port micro op GATHER_ND and its test code from lite #48812

Merged
merged 2 commits into from May 1, 2021

Conversation

rsun-bdti
Copy link
Contributor

Issue #46268. This PR aims to finish porting GATHER_ND from TFL to TFLM.
(This PR combines the originally planned PRS 3, 4, and 5)

Notes:
1 For params/output tensors, only the float and int8_t data types are supported;
2 For indices tensors, only the int32_t data type is supported;
3 The reference implementation in lite/kernels/internal/reference/reference_ops.h was not used, due to the vector used in the reference (possible dynamic allocation);
4 As with the TFL kernel Gather_ND, the TFLM kernel does not yet support batch_dims as of April 23, 2021.

@google-ml-butler google-ml-butler bot added the size:L CL Change Size: Large label Apr 28, 2021
@google-ml-butler
Copy link

Thanks for contributing to TensorFlow Lite Micro.

To keep this process moving along, we'd like to make sure that you have completed the items on this list:

We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review.

@rsun-bdti rsun-bdti self-assigned this Apr 28, 2021
@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@rsun-bdti rsun-bdti added comp:micro Related to TensorFlow Lite Microcontrollers and removed cla: yes labels Apr 28, 2021
@google-cla google-cla bot added the cla: yes label Apr 28, 2021
@google-cla
Copy link

google-cla bot commented Apr 28, 2021

☹️ Sorry, but only Googlers may change the label cla: yes.

@gbaned gbaned self-assigned this Apr 29, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 29, 2021
@gbaned gbaned requested a review from advaitjain April 29, 2021 04:57
@rsun-bdti rsun-bdti requested review from petewarden and removed request for advaitjain April 29, 2021 17:39
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 29, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 29, 2021
@copybara-service copybara-service bot merged commit cd11ef4 into tensorflow:master May 1, 2021
PR Queue automation moved this from Approved by Reviewer to Merged May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:micro Related to TensorFlow Lite Microcontrollers ready to pull PR ready for merge process size:L CL Change Size: Large
Projects
PR Queue
  
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants