Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix numpy 1.20 #49008

Merged
merged 2 commits into from May 13, 2021
Merged

fix numpy 1.20 #49008

merged 2 commits into from May 13, 2021

Conversation

fsx950223
Copy link
Member

@fsx950223 fsx950223 commented May 8, 2021 •
edited

Related #48918

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label May 8, 2021
@google-cla google-cla bot added the cla: yes label May 8, 2021
@gbaned gbaned self-assigned this May 9, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation May 9, 2021
@gbaned gbaned requested a review from advaitjain May 9, 2021 12:23
@bhack
Copy link
Contributor

bhack commented May 12, 2021

I think that >= probably It will be a little bit "out of control" for the TF team. But I could be wrong. /cc @mihaimaruseac

@bhack bhack mentioned this pull request May 12, 2021
Closed
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 12, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer May 12, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 12, 2021
@rthadur rthadur added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels May 12, 2021
@copybara-service copybara-service bot merged commit fc97edb into tensorflow:master May 13, 2021
PR Queue automation moved this from Approved by Reviewer to Merged May 13, 2021
copybara-service bot pushed a commit that referenced this pull request May 13, 2021
@tensorflower-gardener
PR #49008: fix numpy 1.20
07dd16b 
Imported from GitHub PR #49008

Related #48918
Copybara import of the project:

--
e9924bf by fsx950223 <fsx950223@outlook.com>:

fix numpy 1.20

--
509a10c by fsx950223 <fsx950223@outlook.com>:

add test case

PiperOrigin-RevId: 373618749
Change-Id: I925da021db2bdb5a1b35f0d187d0007b7802ff1c
@mihaimaruseac
Copy link
Collaborator

This got rolled back

@bhack
Copy link
Contributor

bhack commented May 14, 2021

This got rolled back

Do you know why?

@mihaimaruseac
Copy link
Collaborator

A TFX test broke, but didn't look into why yet.

@joshua-cogliati-inl joshua-cogliati-inl mentioned this pull request Jul 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@advaitjain advaitjain Awaiting requested review from advaitjain

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@fsx950223 @bhack @mihaimaruseac @kokoro-team @rthadur @gbaned