Remove unused MicroInterpreter::tensor() API. #49114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TensorFlow Lite Micro. To keep this process moving along, we'd like to make sure that you have completed the items on this list:
We would like to have a discussion on the Github issue first to determine the best path forward, and then proceed to the PR review. |
advaitjain
added
kokoro:force-run
The implementation for this function was always allocating a persistent buffer which would mean that calling this function repeatedly would unexpectedly result in an error as a result of running out of space in the arena (basically a memory leak). Additionally, it appears that the function was only being used to test the ResetVariableTensor API.
advaitjain
force-pushed
the
remove-unused-apis
branch
from
d69d158
to
52cd43c
Compare
advaitjain
added
kokoro:force-run
njeffrie
approved these changes
May 11, 2021
Not immediately. I have filed a bug for that -- will figure out how we can test it in a bit. |
|
Got it. I suspect we can add a test along with subgraph support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation for this function was always allocating a persistent buffer which would mean that calling this function repeatedly would unexpectedly result in an error as a result of running out of space in the arena (basically a memory leak).
Additionally, it appears that the function was only being used to test ResetVariableTensor and that test case has also been removed with this change.
http://b/187845286 will be used to add a unit test for ResetVaiableTensor.