Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOSA legalization clean up and rewrite for consistency #49243

Merged
merged 2 commits into from May 20, 2021
Merged

TOSA legalization clean up and rewrite for consistency #49243

merged 2 commits into from May 20, 2021

Conversation

armkevincheng
Copy link
Contributor 

1. use llvm::SmallVector<T> if N is not known at compile time, otherwise use llvm::SmallVector<T,N>.
2. use llvm::SmallVectorImpl<T> as utility function signature.
3. remove unnecessary ArrayRef<T>() cast and replace it with llvm::makeArrayRef() instead if needed.
4. rename get1DConstTensor() into getConstTensor()
5. getConstTensor() is not able to generate TFL::ConstOp now.
6. getConstTensor() can generates N-D constant now.

armkevincheng and others added 2 commits May 14, 2021 12:16
@armkevincheng
TOSA legalization clean up and rewrite for consistency
b1cb9be 
1. use llvm::SmallVector<T> if N is not known at compile time, otherwise use llvm::SmallVector<T,N>.
2. use llvm::SmallVectorImpl<T> as utility function signature.
3. remove unnecessary ArrayRef<T>() cast and replace it with llvm::makeArrayRef() instead if needed.
4. rename get1DConstTensor() into getConstTensor()
5. getConstTensor() is not able to generate TFL::ConstOp now.
6. getConstTensor() can generates N-D constant now.

Signed-off-by: Kevin Cheng <kevin.cheng@arm.com>
Change-Id: Icbd48dcde2ba4b1c1e0e0b74d8f6baae08f78bd0
@armkevincheng
Merge branch 'tensorflow:master' into tosa/iss_02
d225b8c
@google-ml-butler google-ml-butler bot added the size:L CL Change Size: Large label May 17, 2021
@google-cla google-cla bot added the cla: yes label May 17, 2021
@armkevincheng
Copy link
Contributor Author

Still can't edit reviewer myself. Tagging @rsuderman and @stellaraccident for review request.

stellaraccident
stellaraccident approved these changes May 17, 2021
View reviewed changes
Copy link

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanups!

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 17, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 17, 2021
@gbaned gbaned self-assigned this May 18, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation May 18, 2021
@stellaraccident
Copy link

Apologies for this taking some time to merge. We're resolving some issues with it internally.

@copybara-service copybara-service bot merged commit dabceac into tensorflow:master May 20, 2021
PR Queue automation moved this from Assigned Reviewer to Merged May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stellaraccident stellaraccident stellaraccident approved these changes

@joker-eph joker-eph Awaiting requested review from joker-eph

@sanjoy sanjoy Awaiting requested review from sanjoy

@sherhut sherhut Awaiting requested review from sherhut

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:L CL Change Size: Large
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@armkevincheng @stellaraccident @kokoro-team @gbaned