Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made rounding in convert_image_dtype for numbers close to zero #49868

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Made rounding in convert_image_dtype for numbers close to zero #49868

merged 1 commit into from
Sep 21, 2021

Conversation

pointhex
Copy link
Contributor

Fixes #48701

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label May 28, 2021
@google-cla
Copy link

google-cla bot commented May 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 28, 2021
@pointhex
Copy link
Contributor Author

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented May 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented May 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@pointhex
Copy link
Contributor Author

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented May 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented May 28, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes and removed cla: no labels May 28, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 1, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 1, 2021
@rthadur rthadur self-assigned this Jun 3, 2021
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jun 3, 2021
@rthadur
Copy link
Contributor

rthadur commented Jun 3, 2021

@pointhex can you please check build failures ?

@rthadur rthadur removed the ready to pull PR ready for merge process label Jun 3, 2021
@pointhex
Copy link
Contributor Author

pointhex commented Jun 4, 2021

@pointhex can you please check build failures ?

Hi, I will try to do it by the end of the next week. I have and will have a bit busy week. is it ok?

@gbaned gbaned added stat:awaiting response Status - Awaiting response from author comp:ops OPs related issues prtype:bugfix PR to fix a bug labels Jun 10, 2021
@rthadur rthadur assigned gbaned and unassigned rthadur Jun 11, 2021
@gbaned gbaned requested a review from kkimdev June 15, 2021 14:22
@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Jul 6, 2021
@gbaned
Copy link
Contributor

gbaned commented Jul 8, 2021

@pointhex Any update on this PR? Please. Thanks!

@pointhex
Copy link
Contributor Author

@pointhex Any update on this PR? Please. Thanks!

Unfortunately, I don't have. I tried to set up a build on my machine for GPU. But it still doesn't work. I will be on vacation for 2 weeks. So this time I will not have time for work on this commit( So if it hot and can't wait for me. So someone can finish it.
I still think that it is some CPU and GPU computing problem.

@tensorflowbutler tensorflowbutler removed the stat:awaiting response Status - Awaiting response from author label Jul 16, 2021
@gbaned
Copy link
Contributor

gbaned commented Jul 21, 2021

@kkimdev Can you please assist on above comments from @pointhex. Thanks!

@gbaned gbaned added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Jul 28, 2021
@pointhex
Copy link
Contributor Author

@kkimdev Can you please assist on above comments from @pointhex. Thanks!

I'm working on the problem. I managed to install cuda, but getting some errors during builds. Hope it will be solved. And I will check on my machine.

@pointhex
Copy link
Contributor Author

pointhex commented Aug 3, 2021 •
edited

Checked with cuda.
Used two commands:
bazel test --config=cuda --repo_env=CC=clang-12 //tensorflow/python:image_ops_test
bazel test --repo_env=CC=clang-12 //tensorflow/python:image_ops_test
and now tests passes.
Is it right way?

@gbaned gbaned requested a review from kkimdev August 3, 2021 12:09
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Aug 3, 2021
@gbaned gbaned added kokoro:force-run Tests on submitted change and removed stat:awaiting tensorflower Status - Awaiting response from tensorflower labels Aug 5, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 6, 2021
@gbaned gbaned requested review from kkimdev and removed request for kkimdev August 11, 2021 07:49
@pointhex
Copy link
Contributor Author

@kkimdev Could you please approve it?

@gbaned gbaned requested a review from reedwm August 31, 2021 14:00
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 31, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 31, 2021
@gbaned gbaned removed the awaiting review Pull request awaiting review label Sep 1, 2021
@copybara-service copybara-service bot merged commit da582f4 into tensorflow:master Sep 21, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Sep 21, 2021
@shkarupa-alex shkarupa-alex mentioned this pull request Dec 2, 2021
Closed
@shkarupa-alex shkarupa-alex mentioned this pull request Feb 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkimdev kkimdev kkimdev approved these changes

@reedwm reedwm Awaiting requested review from reedwm

Assignees

@gbaned gbaned

Labels
cla: yes comp:ops OPs related issues prtype:bugfix PR to fix a bug size:S CL Change Size: Small
Projects
PR Queue
  
Approved by Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Function used in many augmentations (convert_image_dtype) has an issue
6 participants
@pointhex @rthadur @gbaned @kkimdev @kokoro-team @tensorflowbutler