Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Tensorflow 2.5 requires grpcio 1.34 #50045

Closed
gitpushdashf opened this issue Jun 3, 2021 · 9 comments
Closed

Python: Tensorflow 2.5 requires grpcio 1.34 #50045

gitpushdashf opened this issue Jun 3, 2021 · 9 comments
Assignees
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower TF 2.5 Issues related to TF 2.5 type:bug Bug type:build/install Build and install issues

Comments

@gitpushdashf
Copy link

Tensorflow 2.5.0 requires grpcio 1.34, which prevents installation with some other packages that require 1.37 and later.

Related: #48109, f1a51f0#diff-f526feeafa1000c4773410bdc5417c4022cb2c7b686ae658b629beb541ae9112

It seems like the above commit should've landed for 2.5.0, but it appears to not be that way in pypi.

Log output from Poetry:

(snip)
And because tensorflow (2.5.0) depends on grpcio (>=1.34.0,<1.35.0),
(snip)
@gitpushdashf gitpushdashf added the type:bug Bug label Jun 3, 2021
@tilakrayal tilakrayal added TF 2.5 Issues related to TF 2.5 type:build/install Build and install issues labels Jun 4, 2021
@tilakrayal tilakrayal assigned ymodak and unassigned tilakrayal Jun 4, 2021
@ymodak ymodak added the stat:awaiting tensorflower Status - Awaiting response from tensorflower label Jun 4, 2021
@ymodak
Copy link
Contributor

ymodak commented Jun 4, 2021

On master I see

%PY_EXE% -m pip install "grpcio >= 1.37.0, < 2.0"

@mihaimaruseac
Copy link
Collaborator

This is the only relevant direct dependency on grpcio on TF:

REQUIRED_PACKAGES.append('grpcio >= 1.37.0, < 2.0')

Can you post the output of pip list and details about the architecture you are on?

@mihaimaruseac
Copy link
Collaborator

mihaimaruseac commented Jun 8, 2021

Oh, sorry, you meant the 2.5 release. There we indeed pin to 1.34.

# grpcio does not build correctly on big-endian machines due to lack of
# BoringSSL support.
# See https://github.com/tensorflow/tensorflow/issues/17882.
if sys.byteorder == 'little':
REQUIRED_PACKAGES.append('grpcio ~= 1.34.0')

Unfortunately, we won't be able to alter this without doing a patch release. We currently need to do patch releases for the vulns mentions in the 2.5 release notes and we're also very close to the 2.6 release. So let's wait until 2.6 and there this issue would be solved.

In the future, we will add automation to ensure dependencies are updated before release (CC @pak-laura FYI)

@gitpushdashf
Copy link
Author

That sounds good. Thank you!

@ymodak ymodak closed this as completed Jun 21, 2021
@google-ml-butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

@gitpushdashf
Copy link
Author

Why was this closed? I don't see a 2.6.0 release.

@ymodak
Copy link
Contributor

ymodak commented Aug 12, 2021

TF 2.6 has now released https://github.com/tensorflow/tensorflow/releases/tag/v2.6.0
Perhaps we can close this thread now.

@gitpushdashf
Copy link
Author

Working for me, thank you!

@google-ml-butler
Copy link

Are you satisfied with the resolution of your issue?
Yes
No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:awaiting tensorflower Status - Awaiting response from tensorflower TF 2.5 Issues related to TF 2.5 type:bug Bug type:build/install Build and install issues
Projects
None yet
Development

No branches or pull requests

4 participants