Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PluggableDevice] Add TF_OpKernelConstruction_GetAttrTensor and TF_OpKernelConstruction_GetAttrTensorList #50140

Merged

Conversation

PatriceVignola
Copy link
Contributor

Add TF_OpKernelConstruction_GetAttrTensor and TF_OpKernelConstruction_GetAttrTensorList to the Pluggable Device C API.

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Jun 8, 2021
@google-cla google-cla bot added the cla: yes label Jun 8, 2021
@rthadur rthadur self-assigned this Jun 8, 2021
@rthadur rthadur requested a review from sjamesr June 8, 2021 22:21
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Jun 8, 2021
@rthadur rthadur assigned gbaned and unassigned rthadur Jun 11, 2021
@gbaned gbaned added the awaiting review Pull request awaiting review label Jul 2, 2021
@gbaned gbaned requested a review from saxenasaurabh July 2, 2021 17:50
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Sep 22, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 22, 2021
@gbaned gbaned removed the awaiting review Pull request awaiting review label Sep 23, 2021
@@ -291,6 +293,133 @@ TEST_F(TestKernelAttr, StringList) {
CreateAndCallKernelWithAttr(my_create_func, "TestKernelAttrStringList", v);
}

TEST_F(TestKernelAttr, Tensor) {
struct TensorProtoData : public ::tensorflow::TensorProto {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to break internal builds since ::tensorflow::TensorProto is marked final (not sure why the OSS tests pass). Could we avoid subclassing TensorProto here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Sep 23, 2021
@google-cla
Copy link

google-cla bot commented Sep 23, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Sep 23, 2021
@PatriceVignola
Copy link
Contributor Author

@googlebot I fixed it.

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 23, 2021
@copybara-service copybara-service bot merged commit b42f1d2 into tensorflow:master Sep 28, 2021
@google-ml-butler google-ml-butler bot removed ready to pull PR ready for merge process kokoro:force-run Tests on submitted change labels Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:M CL Change Size: Medium
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

5 participants