-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PluggableDevice] Add TF_OpKernelConstruction_GetAttrTensor and TF_OpKernelConstruction_GetAttrTensorList #50140
[PluggableDevice] Add TF_OpKernelConstruction_GetAttrTensor and TF_OpKernelConstruction_GetAttrTensorList #50140
Conversation
…KernelConstruction_GetAttrTensorList
tensorflow/c/kernels_test.cc
Outdated
@@ -291,6 +293,133 @@ TEST_F(TestKernelAttr, StringList) { | |||
CreateAndCallKernelWithAttr(my_create_func, "TestKernelAttrStringList", v); | |||
} | |||
|
|||
TEST_F(TestKernelAttr, Tensor) { | |||
struct TensorProtoData : public ::tensorflow::TensorProto { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to break internal builds since ::tensorflow::TensorProto
is marked final (not sure why the OSS tests pass). Could we avoid subclassing TensorProto
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
09ffd4d
to
83d1e66
Compare
@googlebot I fixed it. |
Add TF_OpKernelConstruction_GetAttrTensor and TF_OpKernelConstruction_GetAttrTensorList to the Pluggable Device C API.