Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding no_rocm tags to current tests that are broken on ROCm. #50331

Merged
merged 7 commits into from Jul 16, 2021
Merged

Adding no_rocm tags to current tests that are broken on ROCm. #50331

merged 7 commits into from Jul 16, 2021

Conversation

stevenireeves
Copy link
Contributor

Tests to be re-enabled after diagnosing, using no_rocm tags so CSB tests pass.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jun 17, 2021
@google-cla google-cla bot added the cla: yes label Jun 17, 2021
sanjoy
sanjoy suggested changes Jun 17, 2021
View reviewed changes
tensorflow/python/distribute/BUILD Outdated Show resolved Hide resolved
@gbaned gbaned self-assigned this Jun 18, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jun 18, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jun 21, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jun 21, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 21, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Jun 21, 2021
@gbaned
Copy link
Contributor

gbaned commented Jun 21, 2021

@stevenireeves Can you please fix build failures ? Thanks!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Jun 23, 2021
@deven-amd deven-amd added the kokoro:force-run Tests on submitted change label Jun 24, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 24, 2021
@deven-amd deven-amd added the kokoro:force-run Tests on submitted change label Jun 24, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 24, 2021
@stevenireeves
Copy link
Contributor Author

@gbaned It's all ready.

@gbaned gbaned added kokoro:force-run Tests on submitted change and removed stat:awaiting response Status - Awaiting response from author labels Jun 24, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 24, 2021
@gbaned gbaned requested a review from sanjoy June 24, 2021 14:14
@gbaned gbaned added the awaiting review Pull request awaiting review label Jun 28, 2021
@gbaned
Copy link
Contributor

gbaned commented Jun 29, 2021

@stevenireeves Can you please resolve conflicts? Thanks!

@gbaned gbaned added stat:awaiting response Status - Awaiting response from author and removed awaiting review Pull request awaiting review labels Jun 29, 2021
@stevenireeves
Copy link
Contributor Author

@gbaned can you run the other tests?

@gbaned gbaned added the kokoro:force-run Tests on submitted change label Jun 29, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jun 29, 2021
@stevenireeves
Copy link
Contributor Author

@gbaned can you remove the awaiting response tag?

@gbaned gbaned added awaiting review Pull request awaiting review and removed stat:awaiting response Status - Awaiting response from author labels Jun 30, 2021
@stevenireeves
Copy link
Contributor Author

@gbaned any updates on this PR?

@gbaned gbaned requested review from sanjoy and removed request for sanjoy July 6, 2021 14:37
@gbaned
Copy link
Contributor

gbaned commented Jul 6, 2021

@gbaned any updates on this PR?

@stevenireeves Sorry for the delay. It is under review phase. Thank you.

@stevenireeves
Copy link
Contributor Author

@gbaned any updates? It's been in review for over a week.

@gbaned gbaned requested a review from cheshire July 14, 2021 16:36
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 14, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 14, 2021
@gbaned gbaned removed the awaiting review Pull request awaiting review label Jul 15, 2021
@copybara-service copybara-service bot merged commit 7b0ac38 into tensorflow:master Jul 16, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Jul 16, 2021
This was referenced Aug 12, 2021
Merged
Merged
@stevenireeves stevenireeves deleted the google-upstream-no-rocm-tests branch January 25, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheshire cheshire cheshire approved these changes

@joker-eph joker-eph Awaiting requested review from joker-eph

@sherhut sherhut Awaiting requested review from sherhut

@sanjoy sanjoy Awaiting requested review from sanjoy

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stevenireeves @gbaned @sanjoy @cheshire @kokoro-team @deven-amd