[Go] use GOOS to distinguish between platforms #50362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
go generate
withintensorflow/go/op
executestensorflow/go/genop/generate.sh
superfluously (twice). This is becausetensorflow/go/genop/generate.win.go
does not follow golang build contraints which, for file suffixes, require an underscore and the full OS name ofwindows
(e.g.,generate_windows.go
). Thus,go generate
runstensorflow/go/genop/generate.go
andtensorflow/go/genop/generate.win.go
on any platform.It is more direct to remove the build constraint and instead distinguish between platforms within the shell script as
go env GOOS
provides the platform name. This also allows the script to be called directly with GOOS set as an environment variable.