add 11 missing out-of-class definitions #50550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangustc07
reviewed
Jul 8, 2021
| @@ -49,8 +54,14 @@ namespace experimental { | |||
| /* static */ constexpr const char* const SaveDatasetV2Op::kShardFuncOtherArgs; | |||
| /* static */ constexpr const char* const SaveDatasetV2Op::kUseShardFunc; | |||
| /* static */ constexpr const char* const SaveDatasetV2Op::kShardFuncTarguments; | |||
| /* static */ constexpr const int SaveDatasetV2Op::kFileFormatVersion; | |||
There was a problem hiding this comment.
This line repeats line 46. Could you confirm?
There was a problem hiding this comment.
Sorry this should be correct. I didn't notice the "V2".
yangustc07
approved these changes
Jul 8, 2021
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
gbaned
approved these changes
Jul 12, 2021
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a broken debug build.