Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configure.py when using bazelisk on Windows #50553

Merged
merged 4 commits into from Jul 14, 2021
Merged

Fix configure.py when using bazelisk on Windows #50553

merged 4 commits into from Jul 14, 2021

Conversation

PatriceVignola
Copy link
Contributor

Bazelisk on Windows has bazel.cmd on the path instead of bazel.exe, which cannot be called simply with bazel when using subprocess.run with shell=False. Instead, we can simply use the full path obtained by the which command.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jul 1, 2021
@google-cla google-cla bot added the cla: yes label Jul 1, 2021
@gbaned gbaned self-assigned this Jul 1, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 1, 2021
@gbaned gbaned requested a review from mihaimaruseac July 1, 2021 05:02
@gbaned gbaned added the awaiting review Pull request awaiting review label Jul 2, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jul 13, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Jul 13, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Jul 13, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Jul 14, 2021
@copybara-service copybara-service bot merged commit 311bd4d into tensorflow:master Jul 14, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PatriceVignola @mihaimaruseac @kokoro-team @gbaned