Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PluggableDevice] add DEVICE_DEFAULT for datasets ops #50600

Conversation

quintinwang5
Copy link
Contributor

Add DEVICE_DEFAULT for datasets ops. This PR is for PluggableDevice.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jul 5, 2021
@google-cla google-cla bot added the cla: yes label Jul 5, 2021
@gbaned gbaned self-assigned this Jul 5, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 5, 2021
@gbaned gbaned requested a review from rohan100jain July 5, 2021 07:13
@gbaned gbaned added comp:core issues related to core part of tensorflow awaiting review Pull request awaiting review labels Jul 5, 2021
@quintinwang5 quintinwang5 force-pushed the quintinwang/datasets_ops_default_device branch from f59be2e to 4d43779 Compare August 23, 2021 05:47
@gbaned gbaned requested review from saxenasaurabh and removed request for saxenasaurabh August 31, 2021 13:19
@gbaned gbaned requested a review from haoyuz September 28, 2021 16:02
@gbaned
Copy link
Contributor

gbaned commented Oct 6, 2021

@saxenasaurabh Can you please review this PR ? Thanks!

@rohan100jain rohan100jain requested review from jsimsa and removed request for rohan100jain October 24, 2021 18:26
@jsimsa
Copy link
Contributor

jsimsa commented Oct 24, 2021

The placement of tf.data ops does not follow standard placement and should not rely on DEFAULT_DEVICE. Same rationale as #50605.

@jsimsa jsimsa closed this Oct 24, 2021
@google-ml-butler google-ml-butler bot removed the awaiting review Pull request awaiting review label Oct 24, 2021
PR Queue automation moved this from Assigned Reviewer to Closed/Rejected Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:core issues related to core part of tensorflow size:S CL Change Size: Small
Projects
PR Queue
  
Closed/Rejected
Development

Successfully merging this pull request may close these issues.

None yet

3 participants