Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault/heap buffer overflow in `{Experimental,}DatasetToTFRecor… #51189

Conversation

mihaimaruseac
Copy link
Collaborator

…d` where dataset is numeric.

Code assumes only strings inputs and then interprets numbers as valid tstrings. Then, when trying to compute the CRC of the record this results in heap buffer overflow.

PiperOrigin-RevId: 387675909
Change-Id: I7396b9b8afc1ac744112af7c0b1cd7bb41e0f556

…d` where dataset is numeric.

Code assumes only strings inputs and then interprets numbers as valid `tstring`s. Then, when trying to compute the CRC of the record this results in heap buffer overflow.

PiperOrigin-RevId: 387675909
Change-Id: I7396b9b8afc1ac744112af7c0b1cd7bb41e0f556
@google-cla google-cla bot added the cla: yes label Aug 5, 2021
@mihaimaruseac mihaimaruseac merged commit 101764b into r2.4 Aug 5, 2021
@mihaimaruseac mihaimaruseac deleted the mm-cherrypick-e0b6e58c328059829c3eb968136f17aa72b6c876-on-r2.4 branch August 5, 2021 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant