Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-TRT MNIST test with V2 converter #51471

Merged
merged 1 commit into from
Oct 4, 2021
Merged

TF-TRT MNIST test with V2 converter #51471

merged 1 commit into from
Oct 4, 2021

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Aug 12, 2021 •
edited

This PR extends the MNIST test to use the V2 converter. We create a saved model, and convert it both with and without dynamic shape mode.

Tagging @bixia1 for review. Tracker #45481

@google-ml-butler google-ml-butler bot added the size:L CL Change Size: Large label Aug 12, 2021
@google-cla google-cla bot added the cla: yes label Aug 12, 2021
@tfeher tfeher mentioned this pull request Aug 12, 2021
Open
@rthadur rthadur self-assigned this Aug 13, 2021
@rthadur rthadur added this to Assigned Reviewer in PR Queue via automation Aug 13, 2021
@rthadur rthadur requested a review from bixia1 August 13, 2021 14:44
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Aug 13, 2021
@bixia1 bixia1 added the comp:gpu:tensorrt Issues specific to TensorRT label Aug 13, 2021
@gbaned gbaned assigned gbaned and unassigned rthadur Aug 17, 2021
@tfeher
Copy link
Contributor Author

tfeher commented Sep 21, 2021

@bixia1 this is ready for review

@tfeher tfeher force-pushed the trt_mnist_test branch 2 times, most recently from eb360d2 to beef275 Compare September 22, 2021 21:12
tfeher
tfeher commented Sep 22, 2021
View reviewed changes
Copy link
Contributor Author

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bixia1 for the comments, I have updated the PR.

tensorflow/python/compiler/tensorrt/test/quantization_mnist_test.py Show resolved Hide resolved
tensorflow/python/compiler/tensorrt/test/quantization_mnist_test.py Outdated Show resolved Hide resolved
tensorflow/python/compiler/tensorrt/test/quantization_mnist_test.py Show resolved Hide resolved
tensorflow/python/compiler/tensorrt/test/quantization_mnist_test.py Outdated Show resolved Hide resolved
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 22, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Sep 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 22, 2021
@gbaned gbaned removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Sep 23, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 24, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 24, 2021
@gbaned
Copy link
Contributor

gbaned commented Sep 29, 2021

@tfeher Can you please resolve conflicts? Thanks!

@gbaned gbaned removed the ready to pull PR ready for merge process label Sep 29, 2021
@tfeher
Copy link
Contributor Author

tfeher commented Sep 29, 2021

@gbaned I have resolved the conflicts.

@gbaned gbaned requested a review from bixia1 September 30, 2021 13:45
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Sep 30, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 30, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 30, 2021
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Sep 30, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Sep 30, 2021
tfeher
tfeher commented Sep 30, 2021
View reviewed changes
Copy link
Contributor Author

@tfeher tfeher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the import line.

PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Sep 30, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 30, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Sep 30, 2021
@gbaned gbaned removed the awaiting review Pull request awaiting review label Oct 1, 2021
@copybara-service copybara-service bot merged commit f649b2b into tensorflow:master Oct 4, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Oct 4, 2021
@tfeher tfeher mentioned this pull request Mar 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bixia1 bixia1 bixia1 approved these changes

@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes comp:gpu:tensorrt Issues specific to TensorRT size:L CL Change Size: Large
Projects
PR Queue
  
Approved by Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tfeher @gbaned @bixia1 @kokoro-team @rthadur