Fix endianness issue of internal data views in LiteralUtilTest (F16) on BE machines #51513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR swaps the data of internal data views on BE machines to make the data format machine endianness dependent.
sanjoy
approved these changes
Aug 18, 2021
google-ml-butler
bot
added
kokoro:force-run
gbaned
removed
awaiting review
|
@kun-lu20 Can you please address Ubuntu Sanity errors? Thanks! |
|
Hi @gbaned , I've reformatted |
|
Hi @sanjoy , could you please take a look again? Thank you very much! |
mihaimaruseac
approved these changes
Sep 3, 2021
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
majnemer
reviewed
Sep 11, 2021
Signed-off-by: Kun-Lu <kun.lu@ibm.com>
|
Hi @majnemer , thanks again for your advice! Could you please approve this PR? |
majnemer
approved these changes
Sep 16, 2021
google-ml-butler
bot
added
kokoro:force-run
|
Thanks @majnemer |
gbaned
added
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LiteralUtilTest.F16in test case//tensorflow/compiler/xla:literal_testfails on Big-Endian systems because the internal data views are in Little-Endian format. This PR swaps the data on BE machines to make the data format machine endianness dependent, so that this test case would pass on both LE and BE systems.