Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown git option: -C #5154

Closed
markusdr opened this issue Oct 24, 2016 · 3 comments
Closed

Unknown git option: -C #5154

markusdr opened this issue Oct 24, 2016 · 3 comments
Labels
stat:contribution welcome Status - Contributions welcome

Comments

@markusdr
Copy link

I'm trying to compile the latest TensorFlow, but I'm getting a git error:

$ bazel build -c opt //tensorflow/tools/pip_package:build_pip_package
INFO: Loading package: @local_config_xcode//
INFO: Found 1 target...
INFO: From Executing genrule //tensorflow/core:version_info_gen:
Unknown option: -C
usage: git [--version] [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
           [-p|--paginate|--no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           [-c name=value] [--help]
           <command> [<args>]
! 

It looks like the git -C option is used, but that is only supported in git version >= 1.8.

It looks like it's not worth requiring git 1.8 just for this?

@asimshankar
Copy link
Contributor

@markusdr : Thanks for the note.
We welcome contributions to make this work with git < 1.8 (you probably have to change things in gen_git_source.py. Feel free to submit a Pull Request.

However, given than git 1.8 is over 4 years old, it may be hard to predict other issues that might arise with using very old versions of git. If you consider it particularly important to work with such old versions of git, I'd be curious to hear your thoughts.

@asimshankar asimshankar added the stat:contribution welcome Status - Contributions welcome label Oct 24, 2016
@drpngx
Copy link
Contributor

drpngx commented Oct 24, 2016

Please watch PR #4580.

@drpngx
Copy link
Contributor

drpngx commented Oct 26, 2016

Submitted. Woohoo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat:contribution welcome Status - Contributions welcome
Projects
None yet
Development

No branches or pull requests

3 participants