Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --config=rbe_lite_linux in .bazelrc #51567

Merged
merged 2 commits into from
Aug 30, 2021
Merged

Add --config=rbe_lite_linux in .bazelrc #51567

merged 2 commits into from
Aug 30, 2021

Conversation

coeuvre
Copy link
Contributor

@coeuvre coeuvre commented Aug 19, 2021 •
edited

Both --config=rbe_cpu_linux and --config=rbe_linux_py3 expand to --config=rbe_linux which includes link opts for avx instructions. However that won't compile Tensorflow Lite.

This PR adds --config=rbe_lite_linux which reuses most of existing flags for building Tensorflow Lite with RBE.

Context: b/195294181

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Aug 19, 2021
@google-cla google-cla bot added the cla: yes label Aug 19, 2021
@coeuvre coeuvre changed the title Add --config=tf_lite_linux in .bazelrc Add --config=rbe_lite_linux in .bazelrc Aug 19, 2021
@gbaned gbaned self-assigned this Aug 19, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 19, 2021
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Aug 19, 2021
mihaimaruseac
mihaimaruseac requested changes Aug 19, 2021
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also document these options in the comments at the beginning of the file please?

PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Aug 19, 2021
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Aug 21, 2021
@coeuvre
Copy link
Contributor Author

coeuvre commented Aug 25, 2021

Added document for the option rbe_lite_linux.

@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Aug 25, 2021
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Aug 25, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 25, 2021
@mihaimaruseac mihaimaruseac changed the title Add --config=rbe_lite_linux in .bazelrc Add --config=rbe_lite_linux in .bazelrc Aug 25, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 25, 2021
@gbaned gbaned removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Aug 26, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 27, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 27, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Aug 30, 2021
@copybara-service copybara-service bot merged commit 5266664 into tensorflow:master Aug 30, 2021
PR Queue automation moved this from Approved by Reviewer to Merged Aug 30, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Aug 30, 2021
@coeuvre coeuvre deleted the tflite-bazelrc branch August 31, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes size:S CL Change Size: Small
Projects
PR Queue
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@coeuvre @mihaimaruseac @gbaned @kokoro-team @tensorflowbutler