Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable XNNPACK for s390x machines #51655

Merged

Conversation

Sidong-Wei
Copy link
Contributor

This PR disable XNNPACK related build targets and function definitions on s390x because XNNPACK is not supported on s390x: https://github.com/google/XNNPACK#supported-architectures
Without this patch, a lot of Lite targets that are not necessarily depending on XNNPACK dependencies will fail to build on s390x, and this patch will allow them to build successfully

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Aug 24, 2021
@google-cla google-cla bot added the cla: yes label Aug 24, 2021
@gbaned gbaned self-assigned this Aug 25, 2021
@gbaned gbaned added the comp:lite TF Lite related issues label Aug 25, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 25, 2021
@gbaned gbaned requested a review from lintian06 August 25, 2021 06:54
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Aug 25, 2021
@gbaned gbaned requested a review from terryheo September 7, 2021 14:38
@gbaned
Copy link
Contributor

gbaned commented Oct 1, 2021

@lintian06/@terryheo Can you please review this PR ? Thanks!

Copy link
Member

@terryheo terryheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 8, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 8, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 8, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Oct 8, 2021
@copybara-service copybara-service bot merged commit b0d01fb into tensorflow:master Oct 18, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Oct 18, 2021
@Flamefire
Copy link
Contributor

The same applies to PPC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:lite TF Lite related issues size:S CL Change Size: Small
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

5 participants