New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash of tf.image.extract_glimpse with negative input #51658
Fix crash of tf.image.extract_glimpse with negative input #51658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Here are the internal errors, @yongtang can you please verify ? Thanks! Traceback (most recent call last): During handling of the above exception, another exception occurred: Traceback (most recent call last): |
This PR tries to fix the issue raised in 51618 where tf.image.extract_glimpse will crash in case of negative input. This PR adds additional checking to allow graceful error message. This PR fixes 51618. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
b0c1d1a
to
ad799ad
Compare
Thanks @mihaimaruseac @gbaned, I have updated the PR with additional exceptions captured. Please give it a try. |
…fb4f0e5c5b62fbc19edf-on-r2.4 Merge pull request #51658 from yongtang:51618-tf.image.extract_glimpse
…fb4f0e5c5b62fbc19edf-on-r2.5 Merge pull request #51658 from yongtang:51618-tf.image.extract_glimpse
…fb4f0e5c5b62fbc19edf-on-r2.6 Merge pull request #51658 from yongtang:51618-tf.image.extract_glimpse
This PR tries to fix the issue raised in #51618 where
tf.image.extract_glimpse will crash in case of negative input.
This PR adds additional checking to allow graceful error message.
This PR fixes #51618.
Signed-off-by: Yong Tang yong.tang.github@outlook.com