Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Intel MKL] Fuse BiasAdd and Gelu with MatMul #51722

Merged

Conversation

mdfaijul
Copy link
Contributor

@mdfaijul mdfaijul commented Aug 27, 2021

This PR is dependent on #51808.

This PR is a fusion of MatMul + BiasAdd + {set of ops from tf.nn.gelu python api}. It has been enabled with oneDNN CPU backend only with grappler remapper graph optimizer.

Since the set of actual ops for tf.nn.gelu python api is heavily dependent on various graph optimizers in the grappler that runs before remapper, a python unit test (tensorflow/python/grappler/remapper_test.py) has been added.

@google-ml-butler google-ml-butler bot added size:L CL Change Size: Large awaiting review Pull request awaiting review labels Aug 27, 2021
@google-cla google-cla bot added the cla: yes label Aug 27, 2021
@gbaned gbaned self-assigned this Aug 30, 2021
@gbaned gbaned added the comp:grappler Grappler related issues label Aug 30, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 30, 2021
@mdfaijul mdfaijul force-pushed the amin/fused-matmul-gelu branch 2 times, most recently from 46e7834 to c212117 Compare September 6, 2021 16:48
@gbaned gbaned requested a review from ezhulenev October 1, 2021 14:41
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 1, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 1, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 1, 2021
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Oct 3, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Oct 11, 2021
@mdfaijul
Copy link
Contributor Author

@ezhulenev I have fixed some build issue. Could you please re-approve it.

@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Oct 11, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 11, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 11, 2021
@copybara-service copybara-service bot merged commit 983ef5c into tensorflow:master Oct 12, 2021
@google-ml-butler google-ml-butler bot removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Oct 12, 2021
@mdfaijul mdfaijul deleted the amin/fused-matmul-gelu branch November 1, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:grappler Grappler related issues size:L CL Change Size: Large
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

5 participants