Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTEL MKL] Not rewrite conv_grad ops to MKL with explicit padding #51868

Merged

Conversation

Srini511
Copy link
Contributor

@Srini511 Srini511 commented Sep 7, 2021

This change is for fixing a unit test tensorflow/python/kernel_tests/depthwise_conv_op_test.py.
The test specifically tests backward ops with explicit padding and oneDNN kernels yet do not support such a case. So we are disabling re-write for such cases.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Sep 7, 2021
@google-cla google-cla bot added the cla: yes label Sep 7, 2021
@gbaned gbaned self-assigned this Sep 8, 2021
@gbaned gbaned added the comp:core issues related to core part of tensorflow label Sep 8, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Sep 8, 2021
@gbaned gbaned requested a review from penpornk September 8, 2021 05:11
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Sep 8, 2021
Copy link
Member

@penpornk penpornk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Sep 21, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Sep 21, 2021
@penpornk penpornk removed the awaiting review Pull request awaiting review label Sep 21, 2021
@copybara-service copybara-service bot merged commit e6d109f into tensorflow:master Sep 22, 2021
@google-ml-butler google-ml-butler bot removed ready to pull PR ready for merge process kokoro:force-run Tests on submitted change labels Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:core issues related to core part of tensorflow size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

3 participants