Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crashes when loading tensor slices with unsupported types. #51918

Merged
merged 1 commit into from Oct 18, 2021
Merged

Prevent crashes when loading tensor slices with unsupported types. #51918

merged 1 commit into from Oct 18, 2021

Conversation

pranve
Copy link

@pranve pranve commented Sep 9, 2021

Also fix the Tensor(const TensorShape&) constructor swapping the LOG(FATAL)
messages for the unset and unsupported types.

PiperOrigin-RevId: 392695027
Change-Id: I4beda7db950db951d273e3259a7c8534ece49354
(cherry picked from commit abcced0)

Also fix the `Tensor(const TensorShape&)` constructor swapping the LOG(FATAL)
messages for the unset and unsupported types.

PiperOrigin-RevId: 392695027
Change-Id: I4beda7db950db951d273e3259a7c8534ece49354
(cherry picked from commit abcced0)
@google-cla
Copy link

google-cla bot commented Sep 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 9, 2021
@gbaned gbaned self-assigned this Sep 10, 2021
@gbaned gbaned added comp:core issues related to core part of tensorflow size:M CL Change Size: Medium labels Sep 10, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Sep 10, 2021
@gbaned
Copy link
Contributor

gbaned commented Sep 10, 2021

@pranve Can you please sign CLA. Thanks!

@gbaned gbaned assigned mihaimaruseac and unassigned gbaned Sep 10, 2021
@pranve
Copy link
Author

pranve commented Sep 21, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 21, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 18, 2021
@mihaimaruseac mihaimaruseac merged commit f9ccdfd into tensorflow:r2.4 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:core issues related to core part of tensorflow size:M CL Change Size: Medium
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

4 participants