[tf.data] move StructuredFunctionWrapper into a separate module
#51947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvignesh1420
force-pushed
the
dataset-ops-refactor-1
branch
from
8b24120
to
ebee4b5
Compare
aaudiber
requested changes
Sep 13, 2021
There was a problem hiding this comment.
Thanks @kvignesh1420.
Regarding the circular dependency with DatasetV2, lazy-loading DatasetV2 at the start of each dataset transformation sgtm.
kvignesh1420
changed the title
StructuredFunctionWrapper into a common moduleStructuredFunctionWrapper into a separate module
|
@aaudiber I have the changes to the current PR. Please take a look. P.S: Thanks for the suggestions related to the future PRs. |
aaudiber
requested changes
Sep 15, 2021
kvignesh1420
force-pushed
the
dataset-ops-refactor-1
branch
3 times, most recently
from
efc4dea
to
c6dd3d3
Compare
refactor using structured_function module use the new API location of structured_function move DEBUG_MODE to dataset_ops
kvignesh1420
force-pushed
the
dataset-ops-refactor-1
branch
from
c6dd3d3
to
0224cb4
Compare
aaudiber
approved these changes
Sep 20, 2021
google-ml-butler
bot
added
kokoro:force-run
rthadur
added
ready to pull
|
@aaudiber any updates on this? Please let me know if any changes are required. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
dataset_ops.pyby moving theStructuredFunctionWrapperclass into acommonmodule. This enables further refactoring of function-specificDatasets.side note for future PR's: after further examination of the function-specific
Datasetclasses (for ex:MapDataset), I see that they inherit fromUnaryDatasetwhich itself inherits fromDatasetV2. And since theDatasetV2class itself needsMapDatasetfor thedef map()functionality, this poses a circular dependency challenge even if we split the classes into different files. Thus, lazy loading would be imminent and the files might get a bit messy.cc: @aaudiber What do you think?