Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 47351 doesn't work as expected. The
msvc_cl_debug
condition would need to be checked against the toolchain, not against the compiler switch, e.g. like this:But even a fix like this would not lead to the desired outcome because
bazel
will add/DEBUG:FULL
indbg
mode after/DEBUG:FASTBUILD
and thus override it. The only way to compile with/DEBUG:FASTBUILD
is using--compilation_mode=fastbuild
or--compilation_mode=dbg --features=fastbuild
. So PR 47351 is not necessary. Thus revert it.