Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert PR #47351 (doesn't work) #51980

Merged

Conversation

jgehw
Copy link
Contributor

@jgehw jgehw commented Sep 13, 2021

PR 47351 doesn't work as expected. The msvc_cl_debug condition would need to be checked against the toolchain, not against the compiler switch, e.g. like this:

selects.config_setting_group(
++    name = "msvc_cl_debug",
++    match_all = [
++        "@bazel_tools//src/conditions:windows_msvc",
++        ":debug",
++    ],
++    visibility = ["//visibility:public"],
++)

But even a fix like this would not lead to the desired outcome because bazel will add /DEBUG:FULL in dbg mode after /DEBUG:FASTBUILD and thus override it. The only way to compile with /DEBUG:FASTBUILD is using --compilation_mode=fastbuild or --compilation_mode=dbg --features=fastbuild. So PR 47351 is not necessary. Thus revert it.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Sep 13, 2021
@google-cla google-cla bot added the cla: yes label Sep 13, 2021
@gbaned gbaned self-assigned this Sep 14, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Sep 14, 2021
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Sep 14, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 4, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 4, 2021
@copybara-service copybara-service bot merged commit c29040f into tensorflow:master Oct 5, 2021
@google-ml-butler google-ml-butler bot removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Oct 5, 2021
@jgehw jgehw deleted the fix-windows-debug-build-part2 branch October 6, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:S CL Change Size: Small
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

4 participants