[XLA] Make EmitFullWarpShuffleDownLoopForReduce test the required condition. #52082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheshire
approved these changes
Sep 22, 2021
google-ml-butler
bot
added
kokoro:force-run
|
@nouiz Can you please resolve conflicts? Thanks! |
gbaned
added
stat:awaiting response
|
rebased. |
nouiz
force-pushed
the
upstream-EmitFullWarpShuffleDownLoopForReduce
branch
from
72f16d8
to
0cbbc41
Compare
cheshire
approved these changes
Sep 23, 2021
google-ml-butler
bot
added
kokoro:force-run
google-ml-butler
bot
removed
ready to pull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cheshire
This check was recently removed by commit 3b9f82e. As it is very hard to detect an error, it is better to keep it.