Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] Update genop shell script to support module-aware installation #52243

Merged
merged 1 commit into from
Oct 8, 2021
Merged

[Go] Update genop shell script to support module-aware installation #52243

merged 1 commit into from
Oct 8, 2021

Conversation

wamuir
Copy link
Contributor

@wamuir wamuir commented Oct 4, 2021

PR updates genop/generate.sh for Go 1.17 compatibility: the use of go get to install executables is deprecated in Go 1.17.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Oct 4, 2021
@google-cla google-cla bot added the cla: yes label Oct 4, 2021
@gbaned gbaned self-assigned this Oct 4, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 4, 2021
@gbaned gbaned requested a review from faizan-m October 4, 2021 06:12
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Oct 4, 2021
faizan-m
faizan-m approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@faizan-m faizan-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 4, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 4, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 4, 2021
@gbaned gbaned removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Oct 5, 2021
@gbaned
Copy link
Contributor

gbaned commented Oct 5, 2021

@wamuir Can you please fix build failures ? Thanks!

@wamuir
Copy link
Contributor Author

wamuir commented Oct 5, 2021

@gbaned Yes, however I cannot see details on the failing builds. Did these builds run? Can you provide or link to information on the failures? Thanks!

@gbaned gbaned added the kokoro:force-run Tests on submitted change label Oct 6, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 6, 2021
@gbaned gbaned added the ready to pull PR ready for merge process label Oct 6, 2021
@gbaned
Copy link
Contributor

gbaned commented Oct 6, 2021

@gbaned Yes, however I cannot see details on the failing builds. Did these builds run? Can you provide or link to information on the failures? Thanks!

@wamuir I have triggered the build checks again and most of the are successfully completed. No action required from you at this moment. Thank you!

@gbaned gbaned removed the ready to pull PR ready for merge process label Oct 7, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 7, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 7, 2021
@copybara-service copybara-service bot merged commit ea59f93 into tensorflow:master Oct 8, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faizan-m faizan-m faizan-m approved these changes

@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Approved by Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wamuir @gbaned @faizan-m @kokoro-team