[Go] Perform validation on slices when converting Go values to tensors #52257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wamuir
changed the title
mihaimaruseac
requested changes
Oct 5, 2021
@mihaimaruseac please take a look. This seems to be very effective and test takes about 500ms here. Probably this could be replaced by some smarter / less brute approach at a later time. |
mihaimaruseac
approved these changes
Oct 7, 2021
google-ml-butler
bot
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds some validation in NewTensor such that it errors prior to building a tensor in the case of dimension mismatch. 960121c has the side effect of reintroducing the segfaults addressed by #50508, but the approach taken in this latter PR is no longer viable.