Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TF:TRT] Support ConcatV2 op when inputs are constants #52291

Conversation

meena-at-work
Copy link
Contributor

@meena-at-work meena-at-work commented Oct 7, 2021

Inputs to concatV2 can be constants. Previously, we do not convert concatV2 with constant inputs. This PR extends the converter for explicit batch mode to convert concatV2 with constant inputs.

Modify the unit tests to test the conversion for concatV2 with constant inputs.

Signed-off-by: Meenakshi Venkataraman meenakshiv@nvidia.com

Tagging @bixia1 for review
CC: @tfeher @DEKHTIARJonathan

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Oct 7, 2021
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Oct 7, 2021
@google-cla google-cla bot added the cla: yes label Oct 7, 2021
@gbaned gbaned self-assigned this Oct 8, 2021
@gbaned gbaned added the comp:gpu:tensorrt Issues specific to TensorRT label Oct 8, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 8, 2021
@bixia1 bixia1 self-requested a review October 12, 2021 14:16
@bixia1
Copy link
Contributor

bixia1 commented Oct 12, 2021

I modify the PR description, please check.

In explicit batch mode, inputs to the concatV2 op can be constants.

Signed-off-by: Meenakshi Venkataraman <meenakshiv@nvidia.com>
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 12, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 12, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 12, 2021
@copybara-service copybara-service bot merged commit cf8e2c6 into tensorflow:master Oct 13, 2021
@google-ml-butler google-ml-butler bot removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:gpu:tensorrt Issues specific to TensorRT size:M CL Change Size: Medium
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

4 participants