Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r2.7 cherry-pick request: Fix oneDNN-related eager nightly test failures #52326

Merged
merged 2 commits into from Oct 18, 2021

Conversation

penpornk
Copy link
Member

Original PR (merged into master): #52204

Fix //tensorflow/python/kernel_tests:matmul_op_test and run_eager_op_as_function_test, that failed with error "Could not find device for node:" when oneDNN is on.

These failures are because of the recent WrapInCallOp changes 1224326

Detailed explanation from the original PR:

For MKL : we expect WrapInCallOp to be called before we infer device, which marks the '_kernel' attribute as NameChangeOp label for nodeDef of funcDef.
Since with new commit, WrapInCallOp is called AFTER the device inference, no device is found for the MKL Op as no kernel match is found without namechange label.

In this PR: we mark nodeDef with '_kernel' attribute as NameChange label at both places : a) before inferring the device and b) inside WrapInCallOp (already present in current code base)

@google-cla
Copy link

google-cla bot commented Oct 11, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 11, 2021
@penpornk
Copy link
Member Author

Manually setting CLA to yes because these commits are from a PR that is already merged into master (#52204).

@penpornk penpornk added cla: yes and removed cla: no labels Oct 11, 2021
@tilakrayal tilakrayal added comp:core issues related to core part of tensorflow size:S CL Change Size: Small labels Oct 12, 2021
@tilakrayal tilakrayal added this to Assigned Reviewer in PR Queue via automation Oct 12, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 18, 2021
@mihaimaruseac mihaimaruseac merged commit e51e5e7 into tensorflow:r2.7 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:core issues related to core part of tensorflow size:S CL Change Size: Small
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

5 participants