Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r2.7 cherry-pick request: Update MklMatMulPrimitiveFactory to support Arm Compute Library backend #52328

Merged
merged 1 commit into from Oct 18, 2021

Conversation

penpornk
Copy link
Member

@penpornk penpornk commented Oct 11, 2021

Original PR (merged into master): #52261

Add support for caching oneDNN matmul primitives in the mkl_aarch64 build. (Doesn't affect vanilla TF.) The changes in TF are small. Most of the changes are in the patch file for the oneDNN aarch64 repository.

This is more of a performance improvement (feature) PR rather than a performance regression fix. Creating a cherry-pick just in case it can be accepted.

@cfRod Could you please help post some performance numbers here (e.g., how much improvements you saw for some models)? Thank you very much!

Related to issue tensorflow#47415 and PR tensorflow#47775. Adding support for caching matmul primitives.
Updates onednn_acl_primitives.patch to include matmul primitives.
@google-cla
Copy link

google-cla bot commented Oct 11, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 11, 2021
@penpornk
Copy link
Member Author

Manually setting CLA to yes since the commit is from a PR that is already merged into master (#52261).

@penpornk penpornk added cla: yes and removed cla: no labels Oct 11, 2021
@tilakrayal tilakrayal added the comp:core issues related to core part of tensorflow label Oct 12, 2021
@tilakrayal tilakrayal added this to Assigned Reviewer in PR Queue via automation Oct 12, 2021
@cfRod
Copy link
Contributor

cfRod commented Oct 12, 2021

Hi @penpornk, that would be approximately ~2x performance improvements for BERT benchmarks over reference oneDNN.

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 18, 2021
@mihaimaruseac mihaimaruseac merged commit aeff194 into tensorflow:r2.7 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes comp:core issues related to core part of tensorflow
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

4 participants