-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oneDNN] Enable bf16 for SparseSoftmaxCrossEntropyWithLogits #52347
[oneDNN] Enable bf16 for SparseSoftmaxCrossEntropyWithLogits #52347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
BM_SparseXentDev(8, 1000000, cpu, float, DT_FLOAT); | ||
|
||
BM_SparseXentDev(16, 10000, cpu); | ||
BM_SparseXentDev(16, 100000, cpu); | ||
BM_SparseXentDev(16, 10000, cpu, float, DT_FLOAT); | ||
BM_SparseXentDev(16, 100000, cpu, float, DT_FLOAT); | ||
|
||
BM_SparseXentDev(32, 10000, cpu); | ||
BM_SparseXentDev(32, 100000, cpu); | ||
BM_SparseXentDev(32, 10000, cpu, float, DT_FLOAT); | ||
BM_SparseXentDev(32, 100000, cpu, float, DT_FLOAT); | ||
|
||
BM_SparseXentDev(64, 10000, cpu); | ||
BM_SparseXentDev(64, 100000, cpu); | ||
BM_SparseXentDev(64, 10000, cpu, float, DT_FLOAT); | ||
BM_SparseXentDev(64, 100000, cpu, float, DT_FLOAT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe refactor this to a macro? E.g.,
BM_SparseXentDev_CPU(C_TYPE, TF_TYPE)
and call
BM_SparseXentDev_CPU(float, DT_FLOAT)
BM_SparseXentDev_CPU(bfloat16, DT_BFLOAT16)
instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, that sounds good. Submitted the requested change. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes!
No description provided.