-
Notifications
You must be signed in to change notification settings - Fork 74k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tensorflow/compiler/xla/service/gpu/ir_emitter_unnested.cc] Add calls to reserve()
before populating vectors
#52437
Merged
copybara-service
merged 4 commits into
tensorflow:master
from
offscale:tensorflow.compiler.xla.service.gpu.ir_emitter_unnested.cc
Oct 25, 2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to `reserve()` before populating vectors
akuegel
requested changes
Oct 15, 2021
…ect call to `reserve()` before populating vector
joker-eph
reviewed
Oct 15, 2021
…m::SmallVector` over `std::vector` for `slices`
akuegel
approved these changes
Oct 18, 2021
google-ml-butler
bot
added
kokoro:force-run
Tests on submitted change
ready to pull
PR ready for merge process
labels
Oct 18, 2021
akuegel
requested changes
Oct 19, 2021
joker-eph
reviewed
Oct 19, 2021
joker-eph
reviewed
Oct 19, 2021
@SamuelMarks Can you please check @joker-eph's comments and keep us posted ? Thanks! |
@gbaned Done |
joker-eph
approved these changes
Oct 22, 2021
google-ml-butler
bot
added
kokoro:force-run
Tests on submitted change
ready to pull
PR ready for merge process
labels
Oct 22, 2021
gbaned
added
ready to pull
PR ready for merge process
and removed
ready to pull
PR ready for merge process
labels
Oct 22, 2021
akuegel
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51739 (comment) told me to split the larger PR into one PR per file; thus this (thanks
bash
,git
andgh
!)