Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tensorflow/c/c_test_util.cc] Add calls to reserve() before populating vector #52451

Merged
merged 1 commit into from
Oct 25, 2021
Merged

[tensorflow/c/c_test_util.cc] Add calls to reserve() before populating vector #52451

merged 1 commit into from
Oct 25, 2021

Conversation

SamuelMarks
Copy link
Contributor

#51739 (comment) told me to split the larger PR into one PR per file; thus this (thanks bash, git and gh!)

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Oct 15, 2021
@google-cla google-cla bot added the cla: yes label Oct 15, 2021
mihaimaruseac
mihaimaruseac approved these changes Oct 15, 2021
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure of the benefits here as this is a test only utility but just in case it later gets used in prod, let's take it

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 15, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 15, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 18, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Oct 20, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 21, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 21, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 21, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Oct 21, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 21, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 21, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Oct 25, 2021
@copybara-service copybara-service bot merged commit d43bae6 into tensorflow:master Oct 25, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@gbaned gbaned gbaned approved these changes

Assignees

@gbaned gbaned

Labels
cla: yes size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Approved by Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SamuelMarks @mihaimaruseac @gbaned @kokoro-team