Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tensorflow/compiler/mlir/hlo/lib/Analysis/userange_analysis.cc] Add calls to reserve() before populating vector #52466

Conversation

SamuelMarks
Copy link
Contributor

#51739 (comment) told me to split the larger PR into one PR per file; thus this (thanks bash, git and gh!)

…calls to `reserve()` before populating vectors
@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Oct 15, 2021
@google-cla google-cla bot added the cla: yes label Oct 15, 2021
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Oct 15, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 15, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 15, 2021
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Oct 17, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 18, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Oct 18, 2021
@mihaimaruseac mihaimaruseac removed the request for review from sanjoy October 20, 2021 00:24
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Oct 20, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 21, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 21, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 21, 2021
@gbaned gbaned removed the ready to pull PR ready for merge process label Oct 22, 2021
@gbaned
Copy link
Contributor

gbaned commented Oct 22, 2021

@SamuelMarks Can you please resolve conflicts? Thanks!

@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Oct 22, 2021
@SamuelMarks
Copy link
Contributor Author

@gbaned Done

@gbaned gbaned requested a review from joker-eph October 22, 2021 14:37
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 22, 2021
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Oct 25, 2021
copybara-service bot pushed a commit to tensorflow/mlir-hlo that referenced this pull request Oct 26, 2021
…is.cc] Add calls to `reserve()` before populating vector

Imported from GitHub PR tensorflow/tensorflow#52466

tensorflow/tensorflow#51739 (comment) told me to split the larger PR into one PR per file; thus this (thanks `bash`, `git` and `gh`!)
Copybara import of the project:

--
cc99fd8ad768f2354674d130357a3efcce9ba475 by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[tensorflow/compiler/mlir/hlo/lib/Analysis/userange_analysis.cc] Add calls to `reserve()` before populating vectors

PiperOrigin-RevId: 405540491
@copybara-service copybara-service bot merged commit ba01b3b into tensorflow:master Oct 26, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

5 participants