Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tensorflow/compiler/mlir/tensorflow/utils/convert_tensor.cc] Add calls to reserve() before populating vector #52469

Merged
merged 3 commits into from
Oct 22, 2021
Merged

[tensorflow/compiler/mlir/tensorflow/utils/convert_tensor.cc] Add calls to reserve() before populating vector #52469

merged 3 commits into from
Oct 22, 2021

Conversation

SamuelMarks
Copy link
Contributor

#51739 (comment) told me to split the larger PR into one PR per file; thus this (thanks bash, git and gh!)

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Oct 15, 2021
@google-cla google-cla bot added the cla: yes label Oct 15, 2021
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Oct 15, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 15, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 15, 2021
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Oct 17, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 18, 2021
@gbaned gbaned added ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Oct 18, 2021
@gbaned gbaned removed the ready to pull PR ready for merge process label Oct 19, 2021
@SamuelMarks
[tensorflow/compiler/mlir/tensorflow/utils/convert_tensor.cc] Use `ll…
ca7831f 
…vm::SmallVector` over `std::vector` for `original_dimensions`
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Oct 19, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 19, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 19, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 19, 2021
@mihaimaruseac mihaimaruseac removed the request for review from sanjoy October 20, 2021 00:24
@gbaned gbaned removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Oct 20, 2021
@gbaned
Copy link
Contributor

gbaned commented Oct 21, 2021

@SamuelMarks Can you please check @joker-eph's comments and keep us posted ? Thanks!

@SamuelMarks
[tensorflow/compiler/mlir/tensorflow/utils/convert_tensor.cc] No long…
ebf874c 
…er `reserve` on `llvm::SmallVector<int64_t> original_dimensions`
@SamuelMarks
Copy link
Contributor Author

@gbaned Done

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 22, 2021
@copybara-service copybara-service bot merged commit 77eefd8 into tensorflow:master Oct 22, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joker-eph joker-eph joker-eph approved these changes

@jpienaar jpienaar Awaiting requested review from jpienaar

Assignees

@gbaned gbaned

Labels
cla: yes size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Approved by Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SamuelMarks @gbaned @joker-eph @kokoro-team @tensorflowbutler