Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tensorflow/compiler/tf2xla/lib/data_format.cc] Add calls to reserve() before populating vectors #52492

Merged
merged 2 commits into from Oct 20, 2021
Merged

[tensorflow/compiler/tf2xla/lib/data_format.cc] Add calls to reserve() before populating vectors #52492

merged 2 commits into from Oct 20, 2021

Conversation

SamuelMarks
Copy link
Contributor

#51739 (comment) told me to split the larger PR into one PR per file; thus this (thanks bash, git and gh!)

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Oct 15, 2021
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Oct 15, 2021
@google-cla google-cla bot added the cla: yes label Oct 15, 2021
akuegel
akuegel requested changes Oct 15, 2021
View reviewed changes
tensorflow/compiler/tf2xla/lib/data_format.cc Outdated Show resolved Hide resolved
tensorflow/compiler/tf2xla/lib/data_format.cc Outdated Show resolved Hide resolved
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Oct 17, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Oct 18, 2021
@gbaned gbaned requested a review from akuegel October 18, 2021 05:50
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Oct 18, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Oct 18, 2021
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Oct 18, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Oct 18, 2021
@sanjoy sanjoy assigned sanjoy and unassigned sanjoy Oct 19, 2021
@mihaimaruseac mihaimaruseac removed the request for review from sanjoy October 20, 2021 00:14
@gbaned gbaned removed the awaiting review Pull request awaiting review label Oct 20, 2021
@copybara-service copybara-service bot merged commit 7ac0f4c into tensorflow:master Oct 20, 2021
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuegel akuegel akuegel approved these changes

@joker-eph joker-eph Awaiting requested review from joker-eph

Assignees

@gbaned gbaned

Labels
cla: yes size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Approved by Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SamuelMarks @akuegel @sanjoy @kokoro-team @tensorflowbutler @gbaned