Updates config=mkl_aarch64 build to oneDNN 2.4 and Compute Library 21.08 #52518
Conversation
| sha256 = "ccb2dbd9da36cd873cf573b4201d61bdba7438f12b144e6c7d061eb12a641751", | ||
| strip_prefix = "oneDNN-2.3", | ||
| sha256 = "a7f2a4d80d5406d156dfc1d7b27d10b0af5ed061cf0b6197d3d12cddc6790fcb", | ||
| strip_prefix = "oneDNN-2.4", |
There was a problem hiding this comment.
We updated the x86 build to v2.4.1 because v2.4-rc and v2.4 could crash on non-Intel systems due to an XByak issue. Are you affected by this issue?
There was a problem hiding this comment.
We've not seen this issue. The ACL build isn't dependent on Xbyak, and we're not using the Eigen threadpool. So I don't believe we're impacted. But I will test with 2.4.1, it would make sense for the AArch64 build to be on the same oneDNN version.
There was a problem hiding this comment.
I've left the AArch64 build at 2.4.0 for now as, while it would be good to be on exactly the same point release, in this case I don't believe the change will impact us, and would be safer to stick with the version I've been testing with.
There was a problem hiding this comment.
Sounds good. Thank you for the quick responses!
Updates oneDNN version used for `--config=mkl_aarch64` to 2.4 in line with x86 build. Updates Compute Library (used as optimised oneDNN backend on AArch64) to the latest release (21.08). This enables support for SVE and BF16 kernels where hardware supports. This provides a performance uplift of between 1.4x and 3x depending on the hardware support. Removes some patches to oneDNN which are not required for the 2.4 release. NOTE: AArch64 build with --config=mkl_aarch64 requires GCC 10. Change-Id: Iaf7562da729fc928dce922d33c02b8bb0ce74767
nSircombe
force-pushed
the
feature/oneDNN24_ACL2108
branch
from
1b6a128
to
6e4e153
Compare
| sha256 = "ccb2dbd9da36cd873cf573b4201d61bdba7438f12b144e6c7d061eb12a641751", | ||
| strip_prefix = "oneDNN-2.3", | ||
| sha256 = "a7f2a4d80d5406d156dfc1d7b27d10b0af5ed061cf0b6197d3d12cddc6790fcb", | ||
| strip_prefix = "oneDNN-2.4", |
There was a problem hiding this comment.
Sounds good. Thank you for the quick responses!
google-ml-butler
bot
added
kokoro:force-run
|
Hi @penpornk, thanks for giving this your approval. Please could I ask for this change to be considered for cherry-picking onto the 2.7 release branch? |
Updates oneDNN version used for
--config=mkl_aarch64to 2.4in line with x86 build.
Updates Compute Library (used as optimised oneDNN backend
on AArch64) to the latest release (21.08).
This enables support for SVE and BF16 kernels where
hardware supports.
This provides a performance uplift of between 1.4x and 3x
depending on the hardware support.
Removes some patches to oneDNN which are not required for
the 2.4 release.
NOTE: AArch64 build with --config=mkl_aarch64 requires GCC 10.
Change-Id: Iaf7562da729fc928dce922d33c02b8bb0ce74767