Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TF 2.7 release notes #52990

Merged
merged 1 commit into from Nov 10, 2021
Merged

Conversation

nouiz
Copy link
Contributor

@nouiz nouiz commented Nov 8, 2021

Fix #52670. The changes is in TF2.7 and not 2.6.

@mihaimaruseac

@google-cla
Copy link

google-cla bot commented Nov 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 8, 2021
@nouiz nouiz changed the base branch from master to r2.7 November 8, 2021 16:50
@nouiz
Copy link
Contributor Author

nouiz commented Nov 8, 2021

@googlebot I consent.

I already have the CLA signed. I'm not sure why this was asked.

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 8, 2021
@mihaimaruseac
Copy link
Collaborator

CLA bot is confused when doing cherrypicks.

There's a caveat here, we'll add a new commit on the branch after the release, but probably we can handle this the same as #52971

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nouiz
Copy link
Contributor Author

nouiz commented Nov 8, 2021

CLA bot is confused when doing cherrypicks.

I didn't cherry-pick anything here.

There's a caveat here, we'll add a new commit on the branch after the release, but probably we can handle this the same as #52971

Can you confirm that, I need to do this commit on top of master and not on the release branch? I updated this PR to do this. I changed the RELEASE.md files instead of README.md.

@google-cla
Copy link

google-cla bot commented Nov 8, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Nov 8, 2021
@mihaimaruseac
Copy link
Collaborator

So we need one PR against the r2.7 branch and one against master. This way we ensure that the relnotes on the branch are always a subset of what's on master, each section matching.

After the r2.7 branch PR lands I will update the GitHub release notes to match.

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 8, 2021
@nouiz
Copy link
Contributor Author

nouiz commented Nov 8, 2021

Ok. So I updated this PR to be as at the start to modify only the 2.7 branch.

@googlebot I consent.
My commit use an email that is in my github account. So it should works as before.
But my commit name is "Frederic Bastien", while my github account name is "Frédéric Bastien". There is some special character that I converted in the github commit. Can Google bot started to check the name? If so, I'll check if I can use the special character in my github commit.

@gbaned gbaned assigned mihaimaruseac and unassigned gbaned Nov 9, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Nov 9, 2021
@ratan
Copy link

ratan commented Nov 10, 2021

Looks good

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Nov 10, 2021
@mihaimaruseac mihaimaruseac merged commit ab354b5 into tensorflow:r2.7 Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Pull request awaiting review cla: yes size:XL CL Change Size:Extra Large
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

4 participants