[jax] Combine GlobalJitState and ThreadLocalJitState into single JitState #53515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate This avoids duplication when defining new fields. This change also creates standard getters for each field that check if there's thread-local state defined and make sure a global value is set when appropriate.
skye
requested review from
hawkinsp
and removed request for
sanjoy and
joker-eph
hawkinsp
approved these changes
Dec 22, 2021
| @@ -382,7 +382,9 @@ xla::StatusOr<py::object> PmapFunction::Call(py::args args, py::kwargs kwargs) { | |||
| arguments.signature.dynamic_arg_signatures.push_back( | |||
| std::move(signature_or_error).ValueOrDie()); | |||
| } | |||
| arguments.signature.global_extra_jit_context = global_state.extra_jit_context; | |||
| CHECK(global_state.extra_jit_context.has_value()); | |||
There was a problem hiding this comment.
I think I'd avoid the CHECK here and just make the arguments.signature.global_extra_jit_context field optional as well.
google-ml-butler
bot
added
kokoro:force-run
hawkinsp
approved these changes
Dec 22, 2021
google-ml-butler
bot
added
kokoro:force-run
google-ml-butler
bot
removed
awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids duplication when defining new fields. This change also
creates standard getters for each field that check if there's
thread-local state defined and make sure a global value is set when
appropriate.