Add folder pattern for AddOp and MulOp #53553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joker-eph
reviewed
Dec 27, 2021
joker-eph
approved these changes
Dec 27, 2021
google-ml-butler
bot
added
kokoro:force-run
jpienaar
approved these changes
Dec 29, 2021
There was a problem hiding this comment.
I was going to ask about the equivalent of https://llvm.discourse.group/t/canonicalization-of-x-0-0-in-tosa/4760 , but I see for HLOs we don't consider this.
There are some models lowered from tf dialect or torch_xla, they are not lowered from tosa. So I think these folders are meaningful. |
qingyunqu
force-pushed
the
add-normalize-arith
branch
from
3f60589
to
f06d914
Compare
joker-eph
approved these changes
Dec 29, 2021
google-ml-butler
bot
added
kokoro:force-run
gbaned
added
ready to pull
gbaned
approved these changes
Dec 31, 2021
google-ml-butler
bot
added
kokoro:force-run
copybara-service bot
pushed a commit
to tensorflow/mlir-hlo
that referenced
this pull request
Dec 31, 2021
Imported from GitHub PR tensorflow/tensorflow#53553 Add folder pattern: * mhlo.add(%0, 0) -> %0 * mhlo.mul(%0, 1) -> %0 Copybara import of the project: -- f06d914657484570be0aff4aa159cec4c4e98334 by liuyuanqiang <yuanqiangliu@pku.edu.cn>: Add folder pattern for AddOp and MulOp PiperOrigin-RevId: 419128218
google-ml-butler
bot
removed
awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add folder pattern: