Update double-conversion to 3.1.7, and use vendor-provided Bazel BUILD file instead. #53618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D file instead. The double-conversion library used in tensorflow has not been updated for quite some time (previous version used was in 2018) and the Bazel BUILD file was maintained by tensorflow. Recently double-conversion has provided Bazel BUILD file. This PR updates double-conversion to the latest 3.1.7, and use the vendor-provided BUILD file instead so that tensorflow does not need to maintain the Bazel BUILD file separately. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
mihaimaruseac
approved these changes
Jan 5, 2022
google-ml-butler
bot
added
kokoro:force-run
google-ml-butler
bot
removed
awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The double-conversion library used in tensorflow has not been updated for quite some time (previous version used was in 2018) and the Bazel BUILD file was maintained by tensorflow.
Recently double-conversion has provided Bazel BUILD file.
This PR updates double-conversion to the latest 3.1.7, and use the vendor-provided BUILD file instead so that tensorflow does not need to maintain the Bazel BUILD file separately.
Signed-off-by: Yong Tang yong.tang.github@outlook.com