Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default settings for cloud tpu client to support AI Platform #54455

Merged
merged 2 commits into from
May 4, 2022
Merged

Add default settings for cloud tpu client to support AI Platform #54455

merged 2 commits into from
May 4, 2022

Conversation

pshiko
Copy link
Contributor

@pshiko pshiko commented Feb 19, 2022

  • Changed to refer to the value of TPU_CONFIG when no argument is passed to TPU Client.
  • Add unit tests in the above case.

When using TPU with AI Platform, it is necessary to get the TPU information from the environment variable TPU_CONFIG.

Ref: https://cloud.google.com/ai-platform/training/docs/using-tpus#wait-for-tpu-provisioning

These settings aren't interesting and should work with the default settings, just like any other environment like kubernetes or colabolatory.

NOTE:
I understand that Google recommends Vertex AI and CloudTPU VM over AI Platform, but it seems that the use of AI Platform will continue for a while due to insufficient support for scheduled jobs that specify TPU.

@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Feb 19, 2022
@pshiko pshiko changed the title Added default settings for cloud tpu client to support AI Platform Add default settings for cloud tpu client to support AI Platform Feb 19, 2022
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Feb 21, 2022
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Feb 21, 2022
@pshiko
Copy link
Contributor Author

pshiko commented Feb 27, 2022

If you have any additional information you need, please contact me! 👍
@michaelbanfield

@pshiko
Copy link
Contributor Author

pshiko commented Mar 12, 2022

@michaelbanfield CC: @gbaned Any update?

@gbaned gbaned requested a review from allenwang28 March 14, 2022 15:17
@pshiko
Copy link
Contributor Author

pshiko commented Mar 23, 2022

@allenwang28 @michaelbanfield ping😿

@gbaned
Copy link
Contributor

gbaned commented Mar 23, 2022

@allenwang28, @michaelbanfield Can you please review this PR ? Thanks!

@mihaimaruseac mihaimaruseac removed their request for review March 30, 2022 15:53
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 30, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 30, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 30, 2022
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Mar 31, 2022
@pshiko
Copy link
Contributor Author

pshiko commented Mar 31, 2022

When I merged the latest master again and pushed it, it is error with lint.
The parts pointed out in this lint are different from my changes, should I fix them?

@pshiko
Copy link
Contributor Author

pshiko commented Mar 31, 2022

What is said in this PR seems to be relevant.
#55453
#55442

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 31, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 31, 2022
@gbaned gbaned added the cla: yes label Apr 1, 2022
@gbaned
Copy link
Contributor

gbaned commented Apr 1, 2022

@pshiko Can you please fix build failures ? Thanks!

@gbaned gbaned removed ready to pull PR ready for merge process awaiting review Pull request awaiting review labels Apr 1, 2022
@gbaned gbaned added cla: yes kokoro:force-run Tests on submitted change and removed stat:awaiting response Status - Awaiting response from author labels Apr 1, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 1, 2022
@google-cla google-cla bot added cla: no and removed cla: yes labels Apr 1, 2022
@pshiko pshiko mentioned this pull request Apr 1, 2022
Merged
@pshiko pshiko force-pushed the feature/add-aiplatform-tpu-support branch from b7e2545 to 8c9785b Compare April 1, 2022 13:37
@pshiko pshiko force-pushed the feature/add-aiplatform-tpu-support branch from 8c9785b to 5aabb98 Compare April 1, 2022 13:54
@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 1, 2022
@gbaned gbaned added the kokoro:force-run Tests on submitted change label Apr 4, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 4, 2022
@pshiko
Copy link
Contributor Author

pshiko commented Apr 4, 2022

@gbaned
Could you do force run?
Perhaps this PR solved the pylint error.

@gbaned gbaned added the kokoro:force-run Tests on submitted change label Apr 5, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 5, 2022
@gbaned
Copy link
Contributor

gbaned commented Apr 5, 2022 •
edited

@gbaned Could you do force run? Perhaps this PR solved the pylint error.

@pshiko Sure, I have done force run. Thank you.

@gbaned gbaned added the kokoro:force-run Tests on submitted change label Apr 22, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 22, 2022
@gbaned
Copy link
Contributor

gbaned commented Apr 29, 2022 •
edited

Hi @pshiko Still, PyLint errors are appearing, any update on this, please. Thank you!

@gbaned gbaned added the stat:awaiting response Status - Awaiting response from author label Apr 29, 2022
@pshiko
Copy link
Contributor Author

pshiko commented May 1, 2022 •
edited

sorry! I merged the master branch and passed the pylint step.
@gbaned

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 1, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 1, 2022
@gbaned gbaned removed the stat:awaiting response Status - Awaiting response from author label May 2, 2022
@copybara-service copybara-service bot merged commit b566d9a into tensorflow:master May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@allenwang28 allenwang28 allenwang28 approved these changes

@michaelbanfield michaelbanfield Awaiting requested review from michaelbanfield

Assignees

@gbaned gbaned

Labels
cla: yes ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Approved by Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pshiko @gbaned @mihaimaruseac @allenwang28 @kokoro-team