Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MKL BUG fix]fix a minor bug of IsContractionWithAdd #54810

Merged

Conversation

gyshi
Copy link
Contributor

@gyshi gyshi commented Mar 2, 2022

fix a minor bug of IsContractionWithAdd, support Contraction + Add or Contraction + BiasAdd/BiasSemanticAdd + Add pattern shapes inferred.
for example :
Pattern Conv2D + BiasSemanticAdd ({1,} ADD) + Conv2D + BiasAdd.

if do not has this fix, the result is Conv2D + Add + _FusedConv2D(Conv2D + BiasAdd).
after having this fix the result is _FusedConv2D + _FusedConv2D

Contraction + BiasAdd/BiasSemanticAdd + Add fusions shapes inferred.

refactor the function 'IsContractionWithAdd'.

address comments to refactor IsContractionWithAdd again
@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Mar 2, 2022
@gbaned gbaned added the comp:grappler Grappler related issues label Mar 2, 2022
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 2, 2022
@gbaned gbaned requested a review from ezhulenev March 2, 2022 12:32
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Mar 2, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 2, 2022
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Mar 2, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 2, 2022
@gbaned gbaned added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process and removed ready to pull PR ready for merge process labels Mar 3, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 3, 2022
@gbaned gbaned removed the ready to pull PR ready for merge process label Mar 4, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Mar 4, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Mar 4, 2022
@gbaned gbaned added ready to pull PR ready for merge process and removed awaiting review Pull request awaiting review ready to pull PR ready for merge process labels Mar 4, 2022
copybara-service bot pushed a commit that referenced this pull request Mar 7, 2022
FUTURE_COPYBARA_INTEGRATE_REVIEW=#54810 from Intel-tensorflow:gyshi/fiex_remapper_bug 42191f0
PiperOrigin-RevId: 432995652
@copybara-service copybara-service bot merged commit 71151ec into tensorflow:master Mar 7, 2022
@google-ml-butler google-ml-butler bot removed the ready to pull PR ready for merge process label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:grappler Grappler related issues size:M CL Change Size: Medium
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

4 participants