Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TFLite evaluation utils: Fix elinux_armhf build #55402

Merged
merged 1 commit into from May 16, 2022
Merged

TFLite evaluation utils: Fix elinux_armhf build #55402

merged 1 commit into from May 16, 2022

Conversation

lgeiger
Copy link
Contributor

@lgeiger lgeiger commented Mar 28, 2022 •
edited

On master building the evaluation utils for elinux_armhf using

bazel build tensorflow/lite/tools/delegates:hexagon_delegate_provider -c opt --config=elinux_armhf

fails with

ERROR: /code/tensorflow/lite/tools/delegates/BUILD:113:11: Compiling tensorflow/lite/tools/delegates/hexagon_delegate_provider.cc failed: undeclared inclusion(s) in rule '//tensorflow/lite/tools/delegates:hexagon_delegate_provider':
this rule is missing dependency declarations for the following files included by 'tensorflow/lite/tools/delegates/hexagon_delegate_provider.cc':
  'tensorflow/lite/delegates/xnnpack/xnnpack_delegate.h'
Target //tensorflow/lite/tools/delegates:hexagon_delegate_provider failed to build

This PR fixes the issue by effectively reverting 44c0542. The workaround is not needed anymore since the elinux_armhf XNNPACK build has been properly fixed in 4ec84aa.

/cc @terryheo

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Mar 28, 2022
@gbaned gbaned added the comp:lite TF Lite related issues label Mar 28, 2022
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 28, 2022
@gbaned gbaned requested a review from nutsiepully March 28, 2022 13:55
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Mar 28, 2022
@gbaned
Copy link
Contributor

gbaned commented Apr 19, 2022

@nutsiepully Can you please review this PR ? Thank you!

@lgeiger
Copy link
Contributor Author

lgeiger commented May 11, 2022

@nutsiepully @gbaned any chance that this PR could get a review?

terryheo
terryheo approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@terryheo terryheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer May 11, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels May 11, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 11, 2022
@lgeiger
Copy link
Contributor Author

lgeiger commented May 11, 2022

@terryheo thanks 🙏

@copybara-service copybara-service bot merged commit 8dfad7d into tensorflow:master May 16, 2022
@lgeiger lgeiger deleted the fix-rbpi3-build branch May 16, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryheo terryheo terryheo approved these changes

@nutsiepully nutsiepully Awaiting requested review from nutsiepully

Assignees

@gbaned gbaned

Labels
awaiting review Pull request awaiting review comp:lite TF Lite related issues ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Approved by Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lgeiger @gbaned @terryheo @kokoro-team