Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the depthwise Conv2DBackpropFilterNCHW GPU kernel #55751

Merged

Conversation

kaixih
Copy link
Contributor

@kaixih kaixih commented Apr 26, 2022

This PR redesigned the Conv2DBackpropFilterNCHW CUDA kernel to improve the perf by using a more reasonable task partition.

Below is some benchmarking results:

https://docs.google.com/spreadsheets/d/1xKv4QFh2_dzKvf-T2kCJ1qq_ZKd5LW-63Af2nAoS4fw/edit?usp=sharing

cc. @nluehr

@google-ml-butler google-ml-butler bot added the size:M CL Change Size: Medium label Apr 26, 2022
@gbaned gbaned added the comp:core issues related to core part of tensorflow label Apr 26, 2022
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 26, 2022
@gbaned gbaned requested a review from reedwm April 26, 2022 09:31
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Apr 26, 2022
@kaixih kaixih force-pushed the depwise_conv_backprop_filter_devel branch from 082897c to 3436e57 Compare April 26, 2022 16:45
@chsigg chsigg self-requested a review April 26, 2022 19:14
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Apr 26, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 26, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 26, 2022
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label Apr 28, 2022
@copybara-service copybara-service bot merged commit 776ab9f into tensorflow:master May 4, 2022
@duncanriach
Copy link
Contributor

Wow! Nice speedups, @kaixih!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:core issues related to core part of tensorflow ready to pull PR ready for merge process size:M CL Change Size: Medium
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

6 participants