We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Adding a new Op there is the following line of code that describes how to set the shape function:
@tf.RegisterShape("ZeroOut")(common_shapes.call_cpp_shape_fn)
I think this is wrong (you do not want the @ sign since it's not being used as a decorator). Also, having an explicit import would be helpful.
@
So it would be nice to change this to:
from tensorflow.python.framework import common_shapes tf.RegisterShape("ZeroOut")(common_shapes.call_cpp_shape_fn)
The text was updated successfully, but these errors were encountered:
@gibiansky Would you be up for sending a PR?
Sorry, something went wrong.
We can just remove the line now -- by default all ops call their CPP shape function. (Or at least, they will with the next push).
20517b9
vrv
No branches or pull requests
In Adding a new Op there is the following line of code that describes how to set the shape function:
@tf.RegisterShape("ZeroOut")(common_shapes.call_cpp_shape_fn)
I think this is wrong (you do not want the
@
sign since it's not being used as a decorator). Also, having an explicit import would be helpful.So it would be nice to change this to:
The text was updated successfully, but these errors were encountered: