Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bazel apple rules #56787

Merged

Conversation

keith
Copy link
Contributor

@keith keith commented Jul 15, 2022

There are fixes in newer versions of these rules required to build
tensorflow with newer versions of Xcode.

There are fixes in newer versions of these rules required to build
tensorflow with newer versions of Xcode.
@google-ml-butler google-ml-butler bot added the size:S CL Change Size: Small label Jul 15, 2022
@keith
Copy link
Contributor Author

keith commented Jul 15, 2022

AMD ROCm failure appears unrelated

@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jul 18, 2022
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jul 18, 2022
@gbaned gbaned requested review from pak-laura and removed request for learning-to-play August 17, 2022 19:31
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 18, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 18, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 18, 2022
@keith
Copy link
Contributor Author

keith commented Aug 19, 2022

Looks like the macOS jobs are all green here! The other 2 failures appear unrelated, is this good to merge?

@copybara-service copybara-service bot merged commit d5d9952 into tensorflow:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Pull request awaiting review ready to pull PR ready for merge process size:S CL Change Size: Small
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

4 participants