Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a resource #56881

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Added a resource #56881

merged 2 commits into from
Aug 19, 2022

Conversation

alifelham
Copy link
Contributor

No description provided.

@google-ml-butler google-ml-butler bot added the size:XS CL Change Size: Extra Small label Jul 24, 2022
@google-cla
Copy link

google-cla bot commented Jul 24, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Jul 25, 2022
@tilakrayal tilakrayal added this to Assigned Reviewer in PR Queue via automation Jul 25, 2022
@mihaimaruseac mihaimaruseac removed their request for review July 25, 2022 16:09
@gbaned gbaned requested a review from MarkDaoust July 27, 2022 06:54
@gbaned
Copy link
Contributor

gbaned commented Aug 18, 2022

Hi @MarkDaoust Can you please review this PR ? Thank you!

Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Aug 18, 2022
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 18, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Aug 18, 2022
@copybara-service copybara-service bot merged commit e543b11 into tensorflow:master Aug 19, 2022
@alifelham
Copy link
Contributor Author

alifelham commented Aug 19, 2022

Hi, could you please add me as an author to the commit? It doesn't show that I have made a contribution to this approved pull request. @MarkDaoust

@mihaimaruseac
Copy link
Collaborator

e848843 has you as author

Copy link
Contributor Author

@alifelham alifelham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review Pull request awaiting review ready to pull PR ready for merge process size:XS CL Change Size: Extra Small
Projects
PR Queue
  
Approved by Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

5 participants